From: Cosimo Cecchi <cosimoc@gnome.org>
Date: Sat, 14 Mar 2020 21:42:43 +0000 (-0700)
Subject: modemManager: Look for property on correct object
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~751^2^2~135
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=d9a75412c3e843890588a1e794f3014ee65e5619;p=gnome-shell.git

modemManager: Look for property on correct object

The SignalQuality property is defined on the GDBusProxy, not the modem
JS object.
Fix this runtime warning:

JS WARNING: [resource:///org/gnome/shell/misc/modemManager.js 252]: reference to undefined property "SignalQuality"
JS ERROR: TypeError: this.SignalQuality is undefined
_reloadSignalQuality@resource:///org/gnome/shell/misc/modemManager.js:252:34
_init@resource:///org/gnome/shell/misc/modemManager.js:234:14
NMDeviceModem@resource:///org/gnome/shell/ui/status/network.js:517:34
_deviceAdded@resource:///org/gnome/shell/ui/status/network.js:1755:27

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1097
---

diff --git a/js/misc/modemManager.js b/js/misc/modemManager.js
index 21e49e81c..4cc810bbb 100644
--- a/js/misc/modemManager.js
+++ b/js/misc/modemManager.js
@@ -249,7 +249,7 @@ var BroadbandModem = GObject.registerClass({
     }
 
     _reloadSignalQuality() {
-        let [quality, recent_] = this.SignalQuality;
+        let [quality, recent_] = this._proxy.SignalQuality;
         this._setSignalQuality(quality);
     }